Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Merge Refactor/move to delegated compute into Development #929

Merged
merged 10 commits into from
Jun 7, 2024

Conversation

gentlementlegen
Copy link
Member

Resolves #927

@0x4007 @gitcoindev Re-opening the same PR here just to have develop up-to-date and the issue closed.

@gentlementlegen
Copy link
Member Author

@0x4007 Or should have I not merged? Dunno what is the status of develop against this branch, sorry about that.

@0x4007
Copy link
Member

0x4007 commented May 23, 2024

It's fine unless something breaks lol

@gentlementlegen
Copy link
Member Author

@0x4007 Major change is yarn -> bun. Code base seems to follow the same logic. Let's see if the deployment fails, I'll revert.

@0x4007
Copy link
Member

0x4007 commented May 23, 2024

@gentlementlegen
Copy link
Member Author

gentlementlegen commented May 23, 2024

bc4baaf#commitcomment-142323292

@0x4007 Should this mean I should revert? Or just update that file back with all the data

@0x4007
Copy link
Member

0x4007 commented May 23, 2024

Just revert the value to what it was originally.

@gentlementlegen
Copy link
Member Author

@0x4007 Yep this is done. Also the fix I made should go in. Can revert bun update if you want, it was for me to be able to run on Windows, previous version doesn't work.

@0x4007
Copy link
Member

0x4007 commented May 23, 2024

No comment on bun

@gentlementlegen
Copy link
Member Author

@0x4007 Ran this version inside my own repo for testing, commands seem to respond fine.
Meniole/bot#4 (comment)
This version should be working and safe to merge!

@0x4007
Copy link
Member

0x4007 commented May 30, 2024

Check the files view at the bottom. There's an e2e test error related to config!

Also somehow Knip reporter has been running for six days...not sure how that is possible @gitcoindev 👀

Screenshot 2024-05-30 at 15 05 38

@gitcoindev
Copy link
Contributor

Check the files view at the bottom. There's an e2e test error related to config!

Also somehow Knip reporter has been running for six days...not sure how that is possible @gitcoindev 👀

Screenshot 2024-05-30 at 15 05 38

lol let me check this. Six hours should be maximum but normally it takes less than 1 second to execute.

@gitcoindev
Copy link
Contributor

@0x4007 @gentlementlegen I found a most likely cause for the six days run mentioned above - the knip commands were incorrect in package.json and the wokrflow was in a busy loop. The incorrect commands look like an integration error in one of the previous prs. I fixed this and opened #933 . Knip is supposed to fail with findings in this repo and as discussed with @rndquu we will not fix it here since this repo is deprecated, but Knip workflow itself was fixed to avoid leaking secrets with potential malicious pull requests.

@gitcoindev
Copy link
Contributor

For this PR I am not sure about configuration error https://github.com/ubiquity/ubiquibot/actions/runs/9210992288/job/25339291201?pr=929 @gentlementlegen could you please share any information on that?

@gentlementlegen
Copy link
Member Author

gentlementlegen commented May 31, 2024

@gitcoindev Seems that during the tests, env variables were not populated as seen here

So when the configuration is tested it fails as it is undefined.

@gentlementlegen gentlementlegen merged commit 12b702d into development Jun 7, 2024
10 of 13 checks passed
@gentlementlegen gentlementlegen deleted the refactor/move-to-delegated-compute branch June 7, 2024 04:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug Admin Only Permit Generation
3 participants