-
Notifications
You must be signed in to change notification settings - Fork 61
Merge Refactor/move to delegated compute into Development #929
Merge Refactor/move to delegated compute into Development #929
Conversation
…pute Refactor/move to delegated compute
…e issue is not a member
…bership fix: crash on missing membership
@0x4007 Or should have I not merged? Dunno what is the status of develop against this branch, sorry about that. |
It's fine unless something breaks lol |
@0x4007 Major change is yarn -> bun. Code base seems to follow the same logic. Let's see if the deployment fails, I'll revert. |
@0x4007 Should this mean I should revert? Or just update that file back with all the data |
fix: revert configuration
Just revert the value to what it was originally. |
@0x4007 Yep this is done. Also the fix I made should go in. Can revert |
No comment on bun |
@0x4007 Ran this version inside my own repo for testing, commands seem to respond fine. |
Check the files view at the bottom. There's an e2e test error related to config! Also somehow Knip reporter has been running for six days...not sure how that is possible @gitcoindev 👀 |
lol let me check this. Six hours should be maximum but normally it takes less than 1 second to execute. |
@0x4007 @gentlementlegen I found a most likely cause for the six days run mentioned above - the knip commands were incorrect in |
For this PR I am not sure about configuration error https://github.com/ubiquity/ubiquibot/actions/runs/9210992288/job/25339291201?pr=929 @gentlementlegen could you please share any information on that? |
@gitcoindev Seems that during the tests, So when the configuration is tested it fails as it is undefined. |
Resolves #927
@0x4007 @gitcoindev Re-opening the same PR here just to have develop up-to-date and the issue closed.