Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe consider getting rid of some external dependencies #2039

Open
tulilirockz opened this issue Dec 12, 2024 · 7 comments
Open

Maybe consider getting rid of some external dependencies #2039

tulilirockz opened this issue Dec 12, 2024 · 7 comments

Comments

@tulilirockz
Copy link
Collaborator

tulilirockz commented Dec 12, 2024

I don't want to be that security-focused weirdo person that thinks everything is a huuuuge booggie man and is gonna destroy the project, but I feel like as this project is getting more and more traction, we should consider reacessing which external dependencies are being added at least for the base Bluefin images (non -dx).

I'd consider an "external dependency" something that does not come from either the Fedora official repositories (rpm-fusion too), Homebrew packages, Flathub, or our own packages repository (or anything else on our org, like akmods, and others). Considering that, we currently have these external dependencies on base:

On HWE:

On DX we have these:

Other than these there are just things getting pulled from hwe and akmods, nothing really to worry about. But I'd just like to ask you guys if there would be anything that would be best to be moved to packages so that we could have more control over, or just straight up removed from the system

@tulilirockz
Copy link
Collaborator Author

I believe the HWE ones are gonna get removed at some point, arent they? - Otherwise honestly I think just stuff like the ubuntu-fonts copr is kind of redundant since we have them on-repo already

@tulilirockz
Copy link
Collaborator Author

I believe a improvement would be a way to know which coprs are being used for which packages on the packages.json. Currently I believe someone could for example make a custom package w/ the name of another one using an existing copr to inject other programs into the build for example. I know this is being paranoid but its still kinda concerning

@castrojo
Copy link
Member

This has been on the todo for a while so might as well take care of it. The HWE ones go away, I'm fine with deps on the upstreams like k8s, tailscale, starship, etc. Bazitte uses Switcheroo and we work with sentry already, though it might make sense to move that one to ublue-os/packages since bazzite uses it. Hikari is on the ublue core team. The podman-bootc one is run by a redhat and fedora person, and likely has a path into Fedora anyway.

The Incus stuff either gets better in-distro or we may choose to use timothee's sysexts for that.

I feel like fonts should be a separate audit because that's a whole ball of stuff. I forgot what bash-preexec does, I think we use it with distrobox?

@befanyt
Copy link
Contributor

befanyt commented Dec 13, 2024

I forgot what bash-preexec does

FWIW I recognize bash-preexec as option for bash when using atuin.
https://docs.atuin.sh/guide/installation/#installing-the-shell-plugin

@m2Giles
Copy link
Member

m2Giles commented Dec 13, 2024

Bash pre exec is for atuin.

@castrojo
Copy link
Member

Ah! Ok so we had atuin on the image itself at one point, but now it's an opt in install via homebrew, which should pull in everything it needs. So maybe we don't need this on the image anymore?

@befanyt
Copy link
Contributor

befanyt commented Dec 13, 2024

Not sure if this file is being used anymore, but it is pointing to that bash-preexec

Seems to be in use by ujust bluefin-cli via /usr/libexec/ublue-bling.sh

As far as I can tell, brew provides a atuin binary, not your bash setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants