Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install bash-prexec with brew on cli bling #2047

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

GarciaLnk
Copy link
Contributor

this works towards #2039

@GarciaLnk GarciaLnk requested a review from castrojo as a code owner December 14, 2024 23:42
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. brew Issues related to brew.sh integration labels Dec 14, 2024
@@ -20,7 +20,7 @@ fi

if [ "$(basename "$SHELL")" = "bash" ]; then
#shellcheck disable=SC1091
. /usr/share/bash-prexec
[ -f "${HOMEBREW_PREFIX}"/etc/profile.d/bash-preexec.sh ] && . "${HOMEBREW_PREFIX}"/etc/profile.d/bash-preexec.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice! - I'd just add HOMEBREW_PREFIX=${HOMEBREW_PREFIX:-/home/linuxbrew/.linuxbrew} as a default for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@castrojo castrojo enabled auto-merge December 23, 2024 03:34
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 23, 2024
@castrojo castrojo added this pull request to the merge queue Dec 23, 2024
Merged via the queue into ublue-os:main with commit 0fe7aba Dec 23, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brew Issues related to brew.sh integration lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants