fix: luks allow wipe for re-enroll and improve prompt/output #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luks tpm2 auto lock/unlock scripts should not actually reference ujust since they can be used without it. if user has found these ujust recipes, it should be obvious what to do from the ujust list of recipes. Closes: #326
|
Speaking of, might as well fix this instead of tweaking the message. The script should re-enroll the signature if its called again. It's very annoying to have to call unenroll when the hash gets invalidated to re-enroll it. |
|
I think you can remove the whole block that checks if tpm2 is enrolled and just append |
bsherman
changed the title
castrojo
approved these changes
Nov 2, 2024
m2Giles
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
luks tpm2 auto lock/unlock scripts should not actually reference ujust since they can be used without it.
if user has found these ujust recipes, it should be obvious what to do from the ujust list of recipes.
Also, why not wipe and re-enroll.
Closes: #326