This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
feat: Allow users to override secure boot key and password #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… container or action
|
crap, not ready for review. disregard. |
Received error in anaconda when check was hit, need to set as a soft failure to exit the script early without stopping anaconda installation.
|
OK ready for review. For now I am going to stick with a URL since the primary purpose of enrolling a key is to allow our kmods to work. Most users will not require this level of customization and would use our key anyway if they were building off any of our base images with our kmods. |
bsherman
reviewed
Feb 27, 2024
KyleGospo
approved these changes
Feb 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is allowing a user to override the secure boot key and secure boot password to allow them to enroll their own key.
Fixes: #32
What I did