Allow override of USE_SYSTEM_PARTITION #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea that no Android 9 device has a too small system partition is a bit flawed when it comes to devices that were just upgraded to Android 9. Like the Google Pixel, where system partition is only 2GB and Ubuntu Touch needs approx 2.5GB with embedded android image.
The flag files used here will be set in the CI pipeline and packed into the tarball for the system image server, similar to the legacy flag. Like here: https://github.com/ubports/android_bootable_recovery/blob/85ea41287b3c51fa781749c652adec182cf13e0b/system-image-upgrader#L505 and https://gitlab.com/ubports/community-ports/jenkins-ci/halium-build-tools/-/blob/main/phablet-tarball.sh#L35