This repository has been archived by the owner on Nov 4, 2023. It is now read-only.
Notch support #403
Open
Notch support #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a top margin to avoid hiding indicators behind a notch - Add an option in gsettings to revert to the previous behavior - Get the margin in pixels from the device configuration
capsia37
force-pushed
the
xenial_-_indicators-spacing
branch
from
08736fb
to
fda2d40
Compare
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains code changes to support devices with a notch without the need of tweaks:
This PR is ready as a fix for the issue, but integrating the notch permanently in UT would need some more discussion and design.