Upgraded SDK version to fix HCS_E_HYPERV_NOT_INSTALLED undeclared #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. There is no opened automated PR against this one meaning that you changed all the generated files correctly :p Thanks for reaching upstream and let’s merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per conversation on microsoft/WSL-DistroLauncher#103 the recommendation is to upgrade to the latest SDK version. The other option would be define the constant in our sources.
Since GitHub documentation says this version of the SDK is supported on the Windows runners, I opted in for the first option. Should the upstream implement any other fix I'll revisit this topic, but for now this is enough our CI.