Empty definition from google #750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using our own, use the google one in the predefined repository.
didrocks
force-pushed
the
empty-definition-from-google
branch
from
20b3109
to
ba6e0f4
Compare
GabrielNagy
reviewed
Jul 31, 2023
didrocks
force-pushed
the
empty-definition-from-google
branch
from
ba6e0f4
to
eb0da8f
Compare
|
It’s all green now! |
There was a problem hiding this comment.
I wonder if it's worth it though... We are adding a new dependency to some packages in order to save a couple of lines in our proto file and it looks strange to have one of our service types separated in another place, no? This feels like "violating" one of the "goverbs" (a little copy is better than a little dependency)
|
That’s a valid point, worth discussing I guess. |
|
After a good night of thoughts, I think you are right. This has more drawbacks than advantages. Well, at least, that allowed me to fix the generation action to take latest protoc available rather than the one in the current distro. Let’s withdraw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using our own, use the empty google message in the predefined repository.