tests: improve test coverage for main packages #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is hard to explain, but... it's a trick to be able to exercise the main function from within tests without the logic defaulting to starting the client and ultimately failing because there's no socket to connect to. Because `os.Args[0]` is occupied by the Go test runner we can't alter it, so defaulting to starting the daemon is the next best thing.
We can do a smoke test of the main function by telling it to print the version and asserting on the output.
didrocks
reviewed
May 30, 2024
Remove environment prefix since we never used it and it's not documented anywhere, and use decorate to bind the viper flags.
Similarly to how we handle adsysd and adwatchd, handle the Cobra configuration in a separate package that we call from the main package, thus leaving the main package unaware of implementation details.
These tests also cover the commands package as we exercise the main function directly.
This is no longer needed after the admxgen refactor.
GabrielNagy
force-pushed
the
cmd-main-coverage
branch
from
275424a
to
561487d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
+ Coverage 91.40% 93.35% +1.94%
==========================================
Files 78 79 +1
Lines 6890 6877 -13
==========================================
+ Hits 6298 6420 +122
+ Misses 581 447 -134
+ Partials 11 10 -1 ☔ View full report in Codecov by Sentry. |
didrocks
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added details in the individual commit messages, but ultimately this aims to improve coverage for lacking packages such as all main packages for the CLI tools (adsysd/adsysctl, adwatchd, admxgen).
Fixes UDENG-2762