Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UDENG-133 Fixing some i18n problems #658

Closed
wants to merge 5 commits into from
Closed

UDENG-133 Fixing some i18n problems #658

wants to merge 5 commits into from

Commits on Mar 29, 2023

  1. Fixing i18n initialization 

    We use the i18n package both in client.New and in daemon.New. This
happens before we initialize the domain with the right locale, so it
results in improper translations.

Co-authored-by: Edu Gómez Escandell <[email protected]>
    @denisonbarbosa @EduardGomezEscandell
    denisonbarbosa and EduardGomezEscandell committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    3e8f816 View commit details
    Browse the repository at this point in the history

  2. Fixing quote syntax in the long message for cobra.Command 

    Using `` is not recognized by the i18n package, so we were printing
nothing in the message.

Co-authored-by: Edu Gómez Escandell <[email protected]>
    @denisonbarbosa @EduardGomezEscandell
    denisonbarbosa and EduardGomezEscandell committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    97a942c View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Fixed unnecessary call to i18n 

    The message is already translated a few lines earlier.
    @EduardGomezEscandell
    EduardGomezEscandell committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    caf292b View commit details
    Browse the repository at this point in the history

  2. Fixed literal quotes in i18n 

    This fix was auto-generated with
https://github.com/EduardGomezEscandell/go-gettext-adapter
    @EduardGomezEscandell
    EduardGomezEscandell committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    a924c12 View commit details
    Browse the repository at this point in the history

  3. Linter pass

    @EduardGomezEscandell
    EduardGomezEscandell committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    3776607 View commit details
    Browse the repository at this point in the history