Integration tests for certificate policy manager #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having defaults for all needed directories in the certificate Python script, only make the state directory overridable since the others are descendants of it. This will ease integration testing as we will only need to expose the state directory and the global trust directory.
To aid in integration tests, these must be editable via the configuration file.
To be able to use the samba mock in the integration tests we need to append to the PYTHONPATH variable instead of overriding it. This way previously set paths will take precedence.
Removing a directory with `os.removedirs` will fail if it's non-empty. We can circumvent this behavior by using `shutil.rmtree` instead.
Old data - policy configured & disabled Up to date - policy configured & enabled Some things to notice in the tests behavior: - no changes to user golden files with no initial state - purging machine policies removes the samba directory if it exists Fixes UDENG-1059
There was a problem hiding this comment.
Looks great to me!
I do have one comment though (and I'm sorry for not spotting it in the other PR, I noticed it now when looking at the golden files)... Why is the unit test for the certificates manager called TestPolicyApply instead of TestApplyPolicy (which is the actual function name and the pattern that we use)?
|
Mm good catch, I assumed I copied that from a different test file but it seems to be my original creation 😅 - I'll amend the test name. |
Update the certificate test name to match the tested method name (and our convention).
didrocks
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best to review this commit by commit to avoid being overwhelmed by the golden file updates.
Fixes UDENG-1059