Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanly exit if cepces or getcert are not present #762

Merged
merged 4 commits into from
Aug 9, 2023

Commits on Aug 8, 2023

  1. Propagate both stdout and stderr from cert script

    Useful information like Samba logging is printed to stderr. We would
    like to have this information even in the successful runs of the script.
    
    It also adds value to print both stdout and stderr even in the failing
    case.
    GabrielNagy committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    cf6240b View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Set up Samba logging within autoenroll script

    We can leverage Samba's logging system to get a better understanding as
    to what's going on during the lifetime of the autoenroll script.
    
    Mock has to be wrangled a bit to satisfy the actual `lp` object.
    GabrielNagy committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    f156b82 View commit details
    Browse the repository at this point in the history
  2. Cleanly exit if cepces or getcert are not present

    In case certmonger or the cepces library are not installed we do not
    want to fail hard. Check for the existence of the binaries instead of
    debs to be more future-proof given that cepces is not yet packaged in
    Ubuntu.
    
    Fixes UDENG-1156
    GabrielNagy committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    4f33c8b View commit details
    Browse the repository at this point in the history
  3. Create directories after checking for binaries

    In case the binaries needed for certificate autoenrollment are not
    present on the system, avoid creating the needed directories.
    
    Also add a test to illustrate that we will not fail if the directory
    structure is wonky, if certmonger is not present.
    GabrielNagy committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    845ccfe View commit details
    Browse the repository at this point in the history