Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple ota and ldo #17

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Conversation

sehuang
Copy link

@sehuang sehuang commented May 22, 2023

Migrating the simple OTA and LDO generators I made for the May 2023 PLL instance to bag3_analog.

@boblinchuan boblinchuan self-requested a review July 24, 2024 23:47
@boblinchuan boblinchuan self-assigned this Jul 24, 2024
@boblinchuan
Copy link
Member

@sehuang Can you redo this PR with [49042ca](https://github.com/ucb-art/bag3_analog/pull/17/commits/49042ca316e280c8c50d3a1c89434a9a7b4c445f) as the starting commit? The commits prior to that have all been merged in already.

This merge tries to bring the repo up to date before merging in simple_ota_and_ldo
changes. THIS COMMIT NEEDS REVIEW.
@sehuang
Copy link
Author

sehuang commented Jul 26, 2024

@sehuang Can you redo this PR with [49042ca](https://github.com/ucb-art/bag3_analog/pull/17/commits/49042ca316e280c8c50d3a1c89434a9a7b4c445f) as the starting commit? The commits prior to that have all been merged in already.

Oops, I did a merge rather than a rebase. I can redo this as a rebase if you want to preserve the commit history prior to this merge.

It's been a long time since I made this PR, so some of the updates in the RDAC decoder you might want to double check again to make sure they still make sense. I made a hack to res_ladder for sky130 that I explicitly excluded from this PR so it doesn't pollute the upstream generator, but still good to have a second look-over by someone else.

@sehuang sehuang mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants