This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Parse bitwuzla version number to provide appropriate command line args #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekiwi
approved these changes
Feb 26, 2024
| res match { | ||
| case version_regex(major, minor, _) => { | ||
| List("bitwuzla") ++ | ||
| (if (major.toInt == 0 && minor.toInt == 0) { |
There was a problem hiding this comment.
could you add a comment to where you found the info for which flags to use?
| } else { | ||
| List() | ||
| }) ++ | ||
| (if (major.toInt == 0 && minor.toInt < 3) { |
There was a problem hiding this comment.
here a comment to the issue or PR or documentation of bitwuzla would be great
Gallagator
force-pushed
the
bitwuzla_version_support
branch
from
9e83387 to
ecca451
Compare
|
Thanks, just made the comments. I kinda rushed this and didn't think how arbitrary this code would seem without comments. |
Gallagator
force-pushed
the
bitwuzla_version_support
branch
from
ecca451 to
6af9fde
Compare
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #716