Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential deadlock when deleting queue #759

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix potential deadlock when deleting queue #759

wants to merge 1 commit into from

Conversation

robberlang
Copy link

This fixes Issue #758 by using an upgrade lock.

As well, it makes RPCService::send_message thread-safe by using atomic int, and removes a redundant call to TaskExecutionThreadPool::create_queue and uses std::unique_ptr rather than the unnecessary shared_ptr for the request queue in RPCService.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robberlang @AmplabJenkins