upgrade crop module dependency.

[stopfstedt]

Hi,

We'd like to upgrade to the latest version of Crop in the 8.x-2.x branch, this will allow us to provide the Sitefarm profile alongside Acquia Lightning profile in our environment.

Currently, we're running into a dependency conflict with Crop module, so this should fix this.

Thanks!

[mrkmiller]

You can't put docroot because it may not always be docroot. Some use web instead of docroot. As it is, I don't believe this code actually is parsed since it is a dependency. Your root distribution composer.json is where you need to set these.

[eguerin-ucsf]

Yeah unfortunately it seems to manifest as a problem with the merge-extras param in the composer-merge-plugin set to true. I want to have the extras merged between Lightning, Sitefarm_seed and the parent composer.json because they all have various patches that need to be applied. What I find out from this is then it takes the installer-paths from sitefarm_seed which messes up the installation.

Since we are currently applying sitefarm_seed using this stopfstedt version I can set the path, but yes I can see it being an issue. My recommendation would be to remove all installer-paths from the sitefarm_seed composer file. As all the paths should be predefined in the sitefarm-distro composer file anyhow?

Would anyone be willing to review the issues surrounding the Crop update, I don't have access to your ProboCI environment.

[cfblack]

@eguerin-ucsf Probo.ci reports

Drupal\Core\Config\PreExistingConfigException: Configuration objects [error]
69(system.theme) provided by system already exist in active
70configuration in
71/src/sitefarm-distro-template/web/core/lib/Drupal/Core/Config/PreExistingConfigException.php:65
72Stack trace:

etc... during the Drupal site setup
This appears to be a reoccurring issue on pull requests. Probably something that needs to be handled with a change to .probo.yml, not necessarily a problem with your PR.

[mrkmiller]

Please resolve the merge conflicts and limit the scope of this to simply updating the crop module.