Keep recently changed issues in UFixitModal (#887)
#892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is going to be considered, I'd consider reviewing #888 first. Making that change may reduce other error noise, especially for people with new local builds or setups. |
|
I see this being especially helpful for bigger courses; aiming to manually resolve several issues with the filtering involved tends to slow down the process a good bit. |
dmols
approved these changes
Jun 29, 2023
|
Took another peek after a looong time, changes still look functional. I know it's been a hot minute since the changes were made but it's much appreciated, @ssciolla ! Making the merge to dev now (we'll get a bunch of changes from dev to main later on). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #887. It is still a draft.
The changes here make it so multiple issues that have been fixed or resolved remain in the open
UFixitModal. (In constrast, the code inmainonly keeps the most recently changed issue in the modal.) This is intended to assist users in reviewing their work (or potentially un-doing resolves, though that is currently problematic, see #867). It also prevents indexes in the bottom-left of the modal from shrinking by one (because previously fixed or resolved issues aren't being filtered out).The recent state of the issues is set to
falsewhen the modal is closed; thus these "recently updated" issues will not appear in the modal if it is closed and re-opened. That's a departure from current behavior where the most recently updated issue would still appear if you close and reopen the modal with the same filters. My feeling is that clearing this on close would be the expected behavior, but that may be incorrect. Certainly it didn't make sense to keep all updated issues in recent state forever (or at least until the application is refreshed/re-scanned).Some of these decisions/assumptions could benefit from being tested by UX folks.