-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/inventory system #69
Feature/inventory system #69
Conversation
It'll take me a little bit to run through everything, but I wanted to start working on feedback items asap. A few suggestions so far:
|
Thank you so much for the feedback! For the Required Items UI, perhaps a simple "Require Items" button next to Choose Destination that opens a modal would suffice (and would appear only if there are items). This could also make it simpler to include with the Short Answers. |
…modal, adds required items to short answers, fixes player crash, fixes answer occlusion issues
…d width of node manager
…r layout formatting.
…s style for empty question text.
ce36a9f
to
9c1fbec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of potential in the new additions.
I think the working area in the creator can get a bit cramped - some elements can potentially be scaled down, font sizes shrank, etc. to make a little bit more space, but functionally everything new seems to be working well.
Requiring the usage of the 'advanced options' to specify both a minimum and maximum of zero for any given item instead of just allowing the single 0 feels a bit awkward - Potentially treat a single zero as 'the user must have none of this item' and have an optional toggle for 'the user can have any number of this item, even zero' - though that'd be basically the same as the path just being available at all times.
Otherwise, barring some additional things being worked on in separate PRs, this all looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a feature this large, there's likely still going to be additional items to address, but we've tested this pretty well and it feels like a really solid foundation to the inventory system. Approved.
Adventure Inventory System
Creators can create their own items and select or upload icons to these items.
Creators can select items to give players upon visiting a node.
Creators can require certain items for answer choices to be selectable.
The widget will let the player know they are missing an item.
Players receive an alert when they receive an item and can view their inventory by clicking on the backpack icon.
Other changes in this PR include:
What's Left
Player AccessibilityHide background and other options when modals are openAdd aria-labels to buttons and other inventory itemsAdd aria-live updates for new and removed inventory itemsEnsure scoring works with MWDK3