Improve PaginatedList docs
#654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include details for each parameter used in PaginatedList.
Include details for each parameter used in PaginatedList.
|
I'm not sure why the |
|
Looks like some error with the Codecov action not with this PR. I'm don't think I have the permission to look into this any more. Maybe it'll pass when run tomorrow or Monday. |
|
Think I fixed the Codecov thing in #655 and by updating the upload token. (Not sure if it was one, the other, or both, but hey). Get that in and this should hopefully work |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #654 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 3732 3732
=========================================
Hits 3732 3732 ☔ View full report in Codecov by Sentry. |
Thetwam
requested changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include details for each parameter used in
PaginatedList.Fixes #651.