Dev/1.2.0 #70
Dev/1.2.0 #70
Conversation
…stion count when QB is enabled
…to watch questionBankVal
Implemented question bank functionality
…re screen based on content.
Style tweaks to question bank modal
…update-method Adds missing update method to score screen
…red-in-tutorial Tutorial sequence no longer includes feedback
There was a problem hiding this comment.
Most of the changes work well, though I did find a few issues in the creator and player side of the widget.
Here are a few:
- Pressing the 'Tab' button in the player allows the user to move straight to the "Next" button even if an answer isn't selected. This makes the background visible to the user like so:
-
Related to the previous issue, skipping to the next question without an answer selected takes it out of the question total pool, when the score screen is loaded. The score screen actually just considers the questions the user selected an answer for, so technically as long as the user selects one correct answer and skips the rest, they'll get 100% on the widget.
-
'Embed video' button isn't set as a requirement to be pressed, so the widget creator can fill out the remaining components and end up with this in the player.
- Using the 'Q' button to hear the question only works when VO is on. Since the other keys work without VO on, it might be worth specifying that in the keyboard controls modal, if that's how it was originally intended to work.
|
Update: The first two issues I listed seem to only appear in older versions of Google Chrome (I was on 101.0.4). Something about old versions of browsers, that makes the navigation all wonky. On the latest version of Chrome now, and I'm only encountering the last two issues. |
The first of these two is kinda by design, you shouldn't be able to skip questions but if you do, then a log for that question is not generated. The score module will only process questions for logs it receives. Assuming the first issue is resolved with a browser update, the second issue shouldn't occur. Made a small addition to address the second bug by validating the video URL on blur events as well as by clicking on the Embed Video button. Ready for re-review @dmols |
There was a problem hiding this comment.
All three noted features/fixes have been tested:
- Question bank feature is functional; properly randomizes questions, randomization toggle is disabled when QB is enabled
- Score screen changes allow play feedback to update properly. When switching between play attempts, the selected answers for that play are immediately reflected
- Optional feedback is no longer required during the widget tutorial\ (a welcome change).
LGTM 👍
There was a problem hiding this comment.
Fixes look good! I only noticed a few things that could potentially be handled better:
- The div that shows the questions remaining shows "of <total_questions>" first, rather than the actual number for the question you're at. You get to see this once you select an answer or hit the instructions button, for example. I feel it should probably list the number of the question first, then pan to the number of questions total.
- There is no confirmation dialog before completely deleting a question in the creator side. Not sure of the easiest way to go about addressing this, since there isn't much space for say, a "Delete Question?" somewhere near the X. The 'X' button being right next to the title text -- at least with the button in its current size -- could make the user think they're clearing the title, rather than removing the whole question card.
Might just be me nitpicking, so feel free to disregard this and mark the PR as approved, as the big issues have already been addressed and resolved.
|
My suggestions above aren't related to the fixes made on this PR, so I'll add them as potential fixes on the issue board, once it's merged in. Changes here look good and widget runs great! |
updatemethod required to re-render the score screen when viewing a different attempt (Adds missing update method to score screen #71)