ファイルの書き込み時に更新日時を更新する #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uchan-nos
requested changes
Aug 26, 2022
kernel/fat.cpp
Outdated
| dir->file_size = 0; | ||
| if (parent_dir_entry != nullptr) { | ||
| fat::SetWriteTimeToCurrent(*parent_dir_entry); |
There was a problem hiding this comment.
このやり方ではファイルと親ディレクトリの時刻がずれてしまいます。どうせやるなら同時刻を書きたいです。
SetWriteTimeToCurrent が EFI_TIME* を引数に取るようにして、時刻取得は 1 回で済ませるようにしてください。
Linux ではぴったり同じ時刻になるという証拠：
$ mkdir foo_dir
$ ls -la --full-time foo_dir
total 8
drwxr-xr-x 2 uchan uchan 4096 2022-08-26 14:25:51.561915460 +0900 .
drwxr-xr-x 3 uchan uchan 4096 2022-08-26 14:25:51.561915460 +0900 ..
$ touch foo_dir/bar_file
$ ls -la --full-time foo_dir
total 8
drwxr-xr-x 2 uchan uchan 4096 2022-08-26 14:26:04.541915575 +0900 .
drwxr-xr-x 3 uchan uchan 4096 2022-08-26 14:25:51.561915460 +0900 ..
-rw-r--r-- 1 uchan uchan 0 2022-08-26 14:26:04.541915575 +0900 bar_file
$ touch foo_dir/bar_file
$ ls -la --full-time foo_dir
total 8
drwxr-xr-x 2 uchan uchan 4096 2022-08-26 14:26:04.541915575 +0900 .
drwxr-xr-x 3 uchan uchan 4096 2022-08-26 14:25:51.561915460 +0900 ..
-rw-r--r-- 1 uchan uchan 0 2022-08-26 14:26:11.201915635 +0900 bar_file
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #52
ファイルの書き込み (ファイルの作成 = ディレクトリへの書き込み を含む) 時に、ディレクトリエントリ上の更新日時を更新します。
ls -l( #48 ) において、新たに作成したファイルについても1980年ではなく実際の日時が表示されるようになります。