Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Custom Cursor #11

Closed
wants to merge 4 commits into from

Conversation

aaronchan32
Copy link
Member

✨ Tracking

Resolves Issue #10

🌱 Changes

  • Added custom cursor for default cursor and pointer
  • Created cursor SCSS Variables in variables.scss: $cursor and $cursor-pointer

📝 Testing

  • Cursor shows up at all times
  • Pointer cursor can be seen when hovering over the hamburger menu on mobile view

💻 Did you test on all browsers?

  • Yes
  • No

📷Screenshots

image

@aaronchan32 aaronchan32 self-assigned this Mar 28, 2024
@aaronchan32 aaronchan32 linked an issue Mar 28, 2024 that may be closed by this pull request
Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for designfrontiers24 ready!

Name Link
🔨 Latest commit ad1ca58
🔍 Latest deploy log https://app.netlify.com/sites/designfrontiers24/deploys/660d0489e3cc770008afca78
😎 Deploy Preview https://deploy-preview-11--designfrontiers24.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@EdwardNew EdwardNew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just a couple nitpicky things:

  • should hovering over links trigger the pointer cursor? (dco logo, emails, etc)
  • should the cursor's x y be defined for the pointer cursor? (not sure what the values would be but this might help)

@aaronchan32
Copy link
Member Author

LGTM!

Just a couple nitpicky things:

  • should hovering over links trigger the pointer cursor? (dco logo, emails, etc)
  • should the cursor's x y be defined for the pointer cursor? (not sure what the values would be but this might help)

Thanks so much for pointing this out! I think we should have hover on links, and I also updated the cursor hotspot position.

@aaronchan32 aaronchan32 closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Cursor
2 participants