-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix combobox targetRange
for mention input
#2752
base: main
Are you sure you want to change the base?
Fix combobox targetRange
for mention input
#2752
Conversation
🦋 Changeset detectedLatest commit: 3acfad9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you @JannesMeyer for this first contribution! |
Thanks for the PR!
In the future, perhaps we could add a helper function to Plate core (or Slate core) that queues up a callback until the next time |
Thanks for the reply, @12joan :) I just noticed the failing test which expects the combobox state to be updated immediately. I don't know how to resolve that yet, but I will try to think of a solution. |
Description
Fixes #1843
Fixes #2533
After investigating #1843 I discovered that Slate inserts an empty text node before the mention input to fulfil this normalization constraint:
Source: https://docs.slatejs.org/concepts/11-normalizing
Is there any better way to wait for normalization without
setTimeout()
?