Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table attributes disappear during copying #3549 #3550

Conversation

oleg-orlov-quantori
Copy link
Contributor

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

Fix for this issue #3549

Copy link

codesandbox bot commented Sep 18, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: f83f192

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@udecode/plate-table Patch
@udecode/plate-csv Patch
@udecode/plate-docx Patch
@udecode/plate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 9:33am

Copy link
Collaborator

@12joan 12joan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleg-orlov-quantori Thanks for the PR.

We realised that the ability to set arbitrary DOM attributes on elements via the attributes property constitutes a security vulnerability, and we've disabled this feature by default on the latest version of Plate. See the security advistory for more information: GHSA-73rg-f94j-xvhx

Can you edit this PR so that withSetFragmentDataTable respects the node.dangerouslyAllowAttributes configuration option on the table plugin? If dangerouslyAllowAttributes is empty (which is the default case), the attributes property should be ignored.

@oleg-orlov-quantori
Copy link
Contributor Author

@12joan fixed 063bc17

zbeyens
zbeyens previously approved these changes Sep 23, 2024
@zbeyens
Copy link
Member

zbeyens commented Sep 23, 2024

src/react/withSetFragmentDataTable.ts(119,13): error TS2304: Cannot find name 'tablePath'.

@oleg-orlov-quantori
Copy link
Contributor Author

@zbeyens Fixed.
PS
How to install the environment correctly? After yarn install I get errors: "Cannot find module '@udecode/plate-common' or its corresponding type declarations", etc. Because of this, it is difficult to make any changes.

@zbeyens
Copy link
Member

zbeyens commented Sep 23, 2024

Thanks @oleg-orlov-quantori, you need to run yarn build once after install

@zbeyens zbeyens merged commit 5752fec into udecode:main Sep 23, 2024
6 checks passed
@oleg-orlov-quantori oleg-orlov-quantori deleted the fix-table-attributes-disappear-during-copying branch September 23, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants