Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing on Github Actions #841

Merged
merged 5 commits into from
Aug 16, 2023

Conversation

aerorahul
Copy link
Contributor

DESCRIPTION OF CHANGES:

The tests in Github Actions on this repo are broken.
This PR enables build and ctest of the ufs-utils on Github Actions with GCC 10 and Intel One API powered by spack.

This PR adds:

  • dependencies of ufs-utils to be built via spack
  • a workflow for GCC and Intel respectively that builds the dependencies with spack, caches them and then builds ufs-utils. If the build is successful, ctests are also run.

IMO, the staging and downloading of the test data can be significantly improved and caching can be leveraged so that every subsequent push or PR does not force downloading the test data if there has been no change. This can alleviate load on the servers hosting the test data (EMC FTP sites).

TESTS CONDUCTED:

The changes in this PR have no impacts on the use of ufs-utils on on-prem platforms. No tests were run on any of the NOAA platforms.

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera and WCOSS2).
  • Compile branch on Hera using GNU.
  • Compile branch in 'Debug' mode on WCOSS2.
  • Run unit tests locally on any Tier 1 machine.
  • Run relevant consistency tests locally on all Tier 1 machine.

Describe any additional tests performed.
Tests are added as part of github actions and they pass.

The deprecated tests from .github/workflows can be deleted but are left here for the repository maintainers.

DEPENDENCIES:

None

DOCUMENTATION:

None

ISSUE:

Fixes #668

CONTRIBUTORS (optional):

None

@aerorahul
Copy link
Contributor Author

@arunchawla-NOAA FYI

Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aerorahul.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit a8dd34d into ufs-community:develop Aug 16, 2023
4 checks passed
@aerorahul aerorahul deleted the feature/spack branch August 16, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Spack to build dependencies in Github Actions
3 participants