Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gnu compilation on Hera #965

Merged
merged 10 commits into from
Jul 15, 2024
Merged

Fix Gnu compilation on Hera #965

merged 10 commits into from
Jul 15, 2024

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Jun 24, 2024 •
edited
Loading

DESCRIPTION OF CHANGES:

  • Update the Gnu build module on Hera to point to an updated stack.
  • Fix some namelist read logic in global_cycle and cpld_gridgen so it works with Gnu.
  • Minor fix to a preprocessor directive in chgres_cube that Gnu flagged as a warning.

TESTS CONDUCTED:

  • Compile branch on all Tier 1 machines using Intel. Done using 05b6fc2.
  • Compile branch on Hera using GNU. Done using 4dca77a.
  • Compile branch in 'Debug' mode on WCOSS2. Done on Dogwood using 05b6fc2.
  • Run unit tests locally on any Tier 1 machine. Done on Hera using Gnu (4dca77a).
  • Run global_cycle consistency tests locally on all Tier 1 machines (using Intel). Done using 05b6fc2. All tests passed as expected.

All consistency tests were run using Gnu on Hera using 4dca77a. All tests except one global_cycle test ran to completion. The baselines did not always match, but that is expected since they were created using Intel. For more details, see: #962 (comment)

The cpld_gridgen consistency test was run using Intel on Hercules (05b6fc2). All tests passed as expected.

DEPENDENCIES:

None.

DOCUMENTATION:

N/A

ISSUE:

Fixes #962.

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review June 25, 2024 18:41
@GeorgeGayno-NOAA GeorgeGayno-NOAA mentioned this pull request Jul 8, 2024
Closed
@GeorgeGayno-NOAA
Copy link
Collaborator Author

@AlexanderRichert-NOAA - I would like to merge. Any other comments?

AlexanderRichert-NOAA
AlexanderRichert-NOAA approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeorgeGayno-NOAA no other comments

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit de2608b into ufs-community:develop Jul 15, 2024
4 checks passed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UFS_UTILS that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
d3bb0ea 
* origin/develop:
  Update the C192 default ocean resolution in the gdas_init utility (ufs-community#980)
  Use HPC-stack libraries on WCOSS2 (ufs-community#975)
  Fix compiler warning in fre-nctools.fd (ufs-community#969)
  Fix Gnu compilation on Hera (ufs-community#965)
  Update fixed data directory path for Gaea (ufs-community#972)
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the v1.7_spack_hera branch September 25, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderRichert-NOAA AlexanderRichert-NOAA AlexanderRichert-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GNU build on Hera is failing
2 participants
@GeorgeGayno-NOAA @AlexanderRichert-NOAA