-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature epic metrics #2536
base: develop
Are you sure you want to change the base?
Feature epic metrics #2536
Conversation
…stages Signed-off-by: Bruce Kropp <[email protected]>
I have tested this on Hera, Hercules, and Orion. |
on-behalf-of @ufs-community <[email protected]>
on-behalf-of @ufs-community <[email protected]>
This is an old issue for Orion, unrelated to this PR:
probably can remove lines 73 and 222 from ./tests/ci/Jenkinsfile.combined, and just use the latest git on the system: |
on-behalf-of @ufs-community <[email protected]>
Signed-off-by: Bruce Kropp <[email protected]>
…/ufs-weather-model into feature/epic_metrics sync with PR build results
on-behalf-of @ufs-community <[email protected]>
Signed-off-by: Bruce Kropp <[email protected]>
This PR adds almost 2500 lines of non-trivial scripts. I find it impossible to review it by just looking at the code (diff). So, I'm approving this PR based on the assumption that it works for EPIC and that it does whatever it is supposed to do. The PR description does not explain what expected results are or how it can be, if it can be, used on supported platforms without using CI/CD Jenkins scripts. |
@BruceKropp-Raytheon Please explain exactly what this PR is doing, how and why? I don't really see how static pngs (on the dashboard) at all address the original issue which was a) tracking performance over time and b) scraping existing information from commit logs. Does this PR scrape information, or produce it's own (ie, somehow run it's own RT)? |
So it looks like this PR is a combination of features, one which updates the jenkins CI and one which supposedly addresses the metric tracking issue. If it is a combination, it should be split into the relevant parts for basic good CM practice. For the metrics, Dusan was able to spend about an hour implementing something which actually addresses #2527.
Which produces the following
This generates actual useful information, although no pretty pictures. Commit hash 547be6d clearly doubled the run time. If we had seen that at the time, we would have held the PR to determine the cause. |
@DeniseWorthen Relevant JSON will look something like:
We wouldn't expect to produce any images from this here, as those would be derived from the JSON as part of EPIC web dashboard effort. |
Commit Queue Requirements:
Description:
Adding CI/CD scripts to support collection of build and test stage metrics during both Nightly builds and PR builds.
Includes a new Jenksfile that can be tried as a replacement for ./tests/ci/Jenkinsfile.combined.
Potentially resolves issue: #2527
Commit Message:
CI/CD Automation tools to support UFS WM Infrastructure Metrics Dashboard
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: