Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add issue and PR templates #2895

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Add issue and PR templates #2895

merged 3 commits into from
Sep 12, 2023

Conversation

timothy-nunn
Copy link
Contributor

@timothy-nunn timothy-nunn commented Sep 6, 2023 •
edited
Loading

I think having issue templates will be a good QOL change for this repository pre-open-source. These issue templates are mostly taken from bluemira.

We should also add a PR template that reflects the proposed format of #2892.

@timothy-nunn timothy-nunn requested review from jonmaddock and removed request for jonmaddock September 6, 2023 16:21
@timothy-nunn timothy-nunn marked this pull request as draft September 6, 2023 16:25
@timothy-nunn timothy-nunn changed the title Add issue templates Add issue and PR templates Sep 7, 2023
@timothy-nunn timothy-nunn marked this pull request as ready for review September 7, 2023 10:17
jonmaddock
jonmaddock reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look really good Tim. I've got a few questions on the pull request template, which I feel is a bit much, but maybe this is actually useful/standard and we should be doing it. Let me know your comments.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
@jonmaddock jonmaddock mentioned this pull request Sep 12, 2023
Closed
jonmaddock
jonmaddock approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jonmaddock jonmaddock merged commit 25dbe7a into main Sep 12, 2023
20 checks passed
@jonmaddock jonmaddock deleted the timothy-nunn/issue-templates branch September 12, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmaddock jonmaddock jonmaddock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timothy-nunn @jonmaddock