Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHS by rhallerman1 #896 deformatted #900

Merged
merged 48 commits into from
Jul 21, 2023
Merged

LHS by rhallerman1 #896 deformatted #900

merged 48 commits into from
Jul 21, 2023

Conversation

ukrbublik
Copy link
Owner

@ukrbublik ukrbublik commented Apr 3, 2023

Copy of #896 by rhallerman1, restored formating

@codesandbox
Copy link

codesandbox bot commented Apr 3, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 2 resolved Jul 21, 2023 11:23am
react-awesome-query-builder-sandbox ✅ Ready (Inspect) Visit Preview 4 resolved Jul 21, 2023 11:23am
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 11:23am

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bca373e:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration

@rhallerman
Copy link
Contributor

@ukrbublik I'm assuming you didn't make any changes other than deformatting? My branch in the previous PR (#896) seems to work fine, but this one has errors.

@ukrbublik
Copy link
Owner Author

No worries, I fixed tests.
I am polishing this PR locally, will push changes tomorrow I hope.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #900 (bca373e) into master (a04dcbd) will increase coverage by 1.43%.
The diff coverage is 82.50%.

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   80.06%   81.50%   +1.43%     
==========================================
  Files         182      182              
  Lines        8901     9792     +891     
  Branches     1124     1191      +67     
==========================================
+ Hits         7127     7981     +854     
- Misses       1212     1231      +19     
- Partials      562      580      +18     
Impacted Files Coverage Δ
packages/antd/modules/config/index.jsx 93.93% <0.00%> (-2.94%) ⬇️
packages/antd/modules/widgets/value/Boolean.jsx 77.77% <ø> (ø)
packages/antd/modules/widgets/value/Date.jsx 75.00% <ø> (ø)
packages/antd/modules/widgets/value/DateTime.jsx 70.00% <ø> (ø)
...ackages/antd/modules/widgets/value/MultiSelect.jsx 88.23% <ø> (ø)
packages/antd/modules/widgets/value/Number.jsx 70.00% <ø> (ø)
packages/antd/modules/widgets/value/Range.jsx 79.48% <ø> (ø)
packages/antd/modules/widgets/value/Select.jsx 83.87% <ø> (ø)
packages/antd/modules/widgets/value/Slider.jsx 80.55% <ø> (ø)
packages/antd/modules/widgets/value/Text.jsx 80.00% <ø> (ø)
... and 63 more

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants