Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confirmation name and breakdown year in dataset for Export wins. #5356

Merged

Conversation

elcct
Copy link
Contributor

@elcct elcct commented Apr 10, 2024

Description of change

This changes how Breakdown year is calculated, so it is now based off the won date.

It also fixes the confirmation name - it should be loaded from contact name rather than legacy name field.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner April 10, 2024 13:24
@elcct elcct merged commit 4b57206 into main Apr 10, 2024
2 checks passed
@elcct elcct deleted the fix/export-wins-dataset-confirmation-name-and-breakdown-year branch April 10, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants