Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cls2 1025 ingest and match eyb marketing data #5806

Merged

Conversation

marijnkampf
Copy link
Contributor

@marijnkampf marijnkampf commented Nov 18, 2024

Description of change

Define new tasks to:

  • search for new marketing files and
  • ingest the data from said files
  • match records and add marketing data to existing EYB record for those that have a match.

This task uses the marketing serialiser and is triggered by the ingest_user_data task.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@marijnkampf marijnkampf force-pushed the feature/CLS2-1025-ingest-and-match-EYB-marketing-data branch from b409ac8 to 1aaa112 Compare November 18, 2024 15:59
@marijnkampf marijnkampf marked this pull request as ready for review November 18, 2024 16:06
@marijnkampf marijnkampf requested a review from a team as a code owner November 18, 2024 16:06
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.48%. Comparing base (4bf8182) to head (1aaa112).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
datahub/investment_lead/test/test_tasks/utils.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5806   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files        1037     1038    +1     
  Lines       24621    24657   +36     
  Branches     1637     1638    +1     
=======================================
+ Hits        23755    23791   +36     
  Misses        709      709           
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@marijnkampf marijnkampf merged commit 65d5cb9 into main Nov 19, 2024
7 checks passed
@marijnkampf marijnkampf deleted the feature/CLS2-1025-ingest-and-match-EYB-marketing-data branch November 19, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants