Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update site to style the page/sidebar closer to the new styles #706

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update site to style the page/sidebar closer to the new styles #706

wants to merge 1 commit into from
+55 −26

Conversation

CamLamb
Copy link
Contributor

@CamLamb CamLamb commented Aug 23, 2024

Just a small update to bring in the page/sidebar styles as it exists in the designs
Screenshot 2024-08-23 at 12 45 25

Initial thoughts:

  • With the bookmark in the sidebar, it moves to the bottom of the page for narrow screens (mobiles). Which doesn't feel ideal.
  • The bookmark_page_input template currently is a hacky extension of the base card component, this should be updated to a generic component to meet the designs (see below)

Screenshot 2024-08-23 at 12 50 04

@CamLamb CamLamb requested a review from a team as a code owner August 23, 2024 11:50
@CamLamb CamLamb marked this pull request as draft August 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alsyx alsyx alsyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CamLamb @alsyx