Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console #13

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add console #13

wants to merge 15 commits into from

Conversation

lgarvey
Copy link
Member

@lgarvey lgarvey commented Jul 29, 2019

Add a DNB search console

NOTE: This is an early POC and requires a lot of work.

1) Return result metadata - total results, page size etc.
2) Add 'global_ultimate_primary_name'
3) Correctly handle 400 response - return this as a 400 rather than letting the APP 500, and return error detail
4) Handle 404 by returning an empty list with a 200 response
expose sic codes
return unmapped registrsation numbers with original data and indicate that the number is unmapped
return annual sales figures and currency
return employee numbers and is estimated flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant