Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFT-80 Payroll override edit forecast #539

Merged
merged 32 commits into from
Nov 7, 2024

Conversation

CaitBarnard
Copy link
Contributor

@CaitBarnard CaitBarnard commented Oct 31, 2024

If payroll data exists for any row in the forecast table then these values can viewed instead of the default forecast values via a toggle.

Current bugs:

  • Turn on payroll rows, then edit a cell (so that it becomes blue), then turn off the toggle. The edited cell should reset but on a refresh the updated value is actually persisted.

Notes:

  • Needs to be tested with realistic data to confirm decimals are displayed and rounded correctly

//

  • JIRA ticket referenced in title
  • Title is clear and concise
  • Description gives any relevant detail
  • Tests are up to date
  • Documentation is up to date

@CaitBarnard CaitBarnard changed the base branch from main to v2.0/edit-payroll October 31, 2024 13:46
@CaitBarnard CaitBarnard marked this pull request as ready for review November 4, 2024 15:27
@CaitBarnard CaitBarnard requested a review from a team as a code owner November 4, 2024 15:27
@CaitBarnard CaitBarnard changed the title Payroll override edit forecast FFT-80 Payroll override edit forecast Nov 4, 2024
Copy link
Contributor

@SamDudley SamDudley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot's of great work here! I've made a few suggestions. Happy to chat through them on a call.

forecast/views/edit_forecast.py Outdated Show resolved Hide resolved
forecast/templates/forecast/edit/edit.html Outdated Show resolved Hide resolved
forecast/templates/forecast/edit/edit.html Outdated Show resolved Hide resolved
front_end/src/Components/EditForecast/index.jsx Outdated Show resolved Hide resolved
forecast/views/edit_forecast.py Outdated Show resolved Hide resolved
front_end/src/Components/ToggleCheckbox/index.jsx Outdated Show resolved Hide resolved
front_end/src/Util.js Outdated Show resolved Hide resolved
front_end/src/Util.js Outdated Show resolved Hide resolved
front_end/src/Util.js Outdated Show resolved Hide resolved
front_end/src/Components/TableCell/index.jsx Outdated Show resolved Hide resolved
forecast/views/edit_forecast.py Outdated Show resolved Hide resolved
forecast/templates/forecast/edit/edit.html Outdated Show resolved Hide resolved
front_end/src/Components/ToggleCheckbox/index.jsx Outdated Show resolved Hide resolved
front_end/src/Util.js Show resolved Hide resolved
@CaitBarnard CaitBarnard merged commit a48183e into v2.0/edit-payroll Nov 7, 2024
1 check passed
@CaitBarnard CaitBarnard deleted the payroll-override-edit-forecast branch November 7, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants