Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greatuk 1194 footer performance 2 #3417

Merged
merged 10 commits into from
Oct 2, 2024
Merged

Greatuk 1194 footer performance 2 #3417

merged 10 commits into from
Oct 2, 2024

Conversation

davidu1975
Copy link
Contributor

@davidu1975 davidu1975 commented Sep 24, 2024 •
edited
Loading

Performance approvements for the domestic footer used on all Great pages
Using template fragment caching introduced in Wagtail 5.2
Cache footer for 1 day

Workflow

Housekeeping

  • Python requirements have been re-compiled.

Merging

  • This PR can be merged by reviewers. (If unticked, please leave for the author to merge)

@davidu1975 davidu1975 marked this pull request as ready for review October 2, 2024 08:41
@davidu1975 davidu1975 requested a review from a team as a code owner October 2, 2024 08:41
bobby-didcoding
bobby-didcoding approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@bobby-didcoding bobby-didcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidu1975 davidu1975 merged commit 91d3b64 into develop Oct 2, 2024
10 checks passed
@davidu1975 davidu1975 deleted the GREATUK-1194-footer-performance-2 branch October 2, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobby-didcoding bobby-didcoding bobby-didcoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidu1975 @bobby-didcoding