Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for add report data when resetting local db #1362

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

marcuspp
Copy link
Contributor

@marcuspp marcuspp commented Feb 28, 2024

Commands need to be separate as add_reports_data was interrupted as a argument to the other command.

Comment on lines +9 to +10
make manage args="create_icms_groups"
make manage args="add_reports_data"
Copy link
Contributor

@MattHolmes123 MattHolmes123 Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you added this command to the jenkins jobs that populate the dev and staging envs?

@marcuspp marcuspp force-pushed the fix-reset-db-script branch from 317dde3 to a4231ec Compare February 28, 2024 13:27
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (d3b181b) to head (33b4481).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1362   +/-   ##
=======================================
  Coverage   78.97%   78.97%           
=======================================
  Files         294      294           
  Lines       21251    21251           
  Branches     3289     3289           
=======================================
  Hits        16783    16783           
  Misses       3963     3963           
  Partials      505      505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcuspp marcuspp force-pushed the fix-reset-db-script branch from a4231ec to 33b4481 Compare February 28, 2024 15:09
@marcuspp marcuspp force-pushed the fix-reset-db-script branch from 33b4481 to b189296 Compare February 28, 2024 16:10
@marcuspp marcuspp merged commit 6d99389 into main Feb 28, 2024
2 of 3 checks passed
@marcuspp marcuspp deleted the fix-reset-db-script branch February 28, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants