UAT release #2102
Merged
UAT release #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen-suspending-Licence
…hen-suspending-Licence
…hen-suspending-Licence
…hen-suspending-Licence
…details_to_lite_hmrc function
…hen-suspending-Licence
…ding-Licence' of https://github.com/uktrade/lite-api into LTD-5167-turn-off-HMRC-cancellation-message-when-suspending-Licence
…tion-message-when-suspending-Licence LTD-5167-turn-off-HMRC-cancellation-message-when-suspending-Licence
…mendment-status [LTD-5121] Rename superseded by amendment status
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
| @@ -44,7 +45,7 @@ def copy_detail(self, pk): | |||
| return values | |||
|
|
|||
|
|
|||
| class Party(TimestampableModel): | |||
| class Party(TimestampableModel, Clonable): | |||
There was a problem hiding this comment.
This model has lots of fields. Consider splitting into multiple models. More info.
Comment on lines
+137
to
+140
| self.assertTrue( | ||
| strings.Applications.Generic.INVALID_OPERATION_FOR_NON_DRAFT_OR_MAJOR_EDIT_CASE_ERROR | ||
| in resp.content.decode("utf-8") | ||
| ) |
There was a problem hiding this comment.
Suggested change
| self.assertTrue( | |
| strings.Applications.Generic.INVALID_OPERATION_FOR_NON_DRAFT_OR_MAJOR_EDIT_CASE_ERROR | |
| in resp.content.decode("utf-8") | |
| ) | |
| self.assertIn( | |
| strings.Applications.Generic.INVALID_OPERATION_FOR_NON_DRAFT_OR_MAJOR_EDIT_CASE_ERROR, resp.content.decode("utf-8")) |
self.assertIn provides more helpful failure messages than self.assertTrue. Read more.
|
|
||
| def clone(self, exclusions=None, **overrides): | ||
| if not overrides.get("party"): | ||
| cloned_party = self.party.clone() |
There was a problem hiding this comment.
Django automatically creates a related_name if it's not set. If it were set then a more readable and explicit relationship is set up. More.
markj0hnst0n
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim
UAT release