Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move flagging rule functions into lite_routing #2217

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

kevincarrogan
Copy link
Contributor

@kevincarrogan kevincarrogan commented Oct 1, 2024

Aim

This is the conclusion in moving the flagging rule functions into lite_routing that began with https://github.com/uktrade/lite-routing/pull/271.

The other PR duplicated the code that was originally in lite-api and this PR then switches all of the imports to point to that new code.

LTD-5482

@kevincarrogan kevincarrogan force-pushed the LTD-5482-move-flagging-rule-functions branch 7 times, most recently from 6e4facc to 3cff40d Compare October 8, 2024 17:57
@kevincarrogan kevincarrogan marked this pull request as ready for review October 8, 2024 18:33
@currycoder currycoder self-requested a review October 9, 2024 13:03
@kevincarrogan kevincarrogan force-pushed the LTD-5482-move-flagging-rule-functions branch from 3cff40d to f471704 Compare October 10, 2024 09:20
@markj0hnst0n
Copy link
Contributor

The ReadMe still refers to the old place where the code was kept. Not sure whether we want it pointing to the right place now or not.

@markj0hnst0n
Copy link
Contributor

Do you still need the api_workflow_code_exists() function in test_flagging_engine.py now that it's being deleted?

@kevincarrogan
Copy link
Contributor Author

kevincarrogan commented Oct 10, 2024

The ReadMe still refers to the old place where the code was kept. Not sure whether we want it pointing to the right place now or not.

I'm going to be doing a fair few incremental changes so I was planning on updating the documentation once that was done instead of me updating it for each change because some of it will become redundant in later changes anyway.

I'll create a ticket as a reminder to do that though in case I do forget.

@kevincarrogan
Copy link
Contributor Author

Do you still need the api_workflow_code_exists() function in test_flagging_engine.py now that it's being deleted?

I do whilst the lite_routing sha hasn't been updated in lite_api. It's just how our code checks out different branches that means I can't delete it yet.

@kevincarrogan kevincarrogan merged commit c088cc9 into dev Oct 10, 2024
26 checks passed
@kevincarrogan kevincarrogan deleted the LTD-5482-move-flagging-rule-functions branch October 10, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants