Dev-migration-DBT-Platform #2134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-francis-MT
force-pushed
the
dev-migration
branch
from
4d1684a
to
89ecd51
Compare
emileswarts
force-pushed
the
dev-migration
branch
from
89ecd51
to
40851f3
Compare
james-francis-MT
force-pushed
the
dev-migration
branch
from
40851f3
to
89ecd51
Compare
emileswarts
force-pushed
the
dev-migration
branch
5 times, most recently
from
bf2b406
to
8d95070
Compare
james-francis-MT
force-pushed
the
dev-migration
branch
from
9fff461
to
6806cf6
Compare
emileswarts
force-pushed
the
dev-migration
branch
from
6806cf6
to
8ff07ec
Compare
james-francis-MT
force-pushed
the
dev-migration
branch
4 times, most recently
from
242a780
to
549d4f0
Compare
depsiatwal
commented
Sep 18, 2024
depsiatwal
commented
Sep 18, 2024
|
Testing on Dev2 and this looks good |
1 similar comment
|
Testing on Dev2 and this looks good |
james-francis-MT
force-pushed
the
dev-migration
branch
from
b232b40
to
8993bd4
Compare
|
Would it be an idea to deploy this somewhere so we can see it's backwards compatible okay? |
I did test these branches on dev2 all was ok, probably need to retest with most recent changes. |
james-francis-MT
requested review from
kevincarrogan,
hnryjmes and
markj0hnst0n
james-francis-MT
force-pushed
the
dev-migration
branch
from
b28f302
to
c602bd8
Compare
Comment on lines
+205
to
+207
| AWS_ACCESS_KEY_ID = env.str("AWS_ACCESS_KEY_ID", None) | ||
| AWS_SECRET_ACCESS_KEY = env.str("AWS_SECRET_ACCESS_KEY", None) | ||
| AWS_REGION = env.str("AWS_REGION", "eu-west-2") |
There was a problem hiding this comment.
What's the reason this needs to change because of DBT Platform?
There was a problem hiding this comment.
No need for aws creds in aws as it will auto use whatever roll it has for ecs
This causes an error on CodePipeline "Initiated Worker with invalid NODE_OPTIONS env variable: --use-openssl-ca is not allowed in NODE_OPTIONS"
james-francis-MT
force-pushed
the
dev-migration
branch
from
a383815
to
d16eb24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.