TSS-1694-1695: Data workspace additions #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osimuka
approved these changes
Jul 1, 2024
abarolo
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #822 +/- ##
===========================================
+ Coverage 86.35% 86.40% +0.04%
===========================================
Files 166 166
Lines 8277 8278 +1
===========================================
+ Hits 7148 7153 +5
+ Misses 1129 1125 -4 ☔ View full report in Codecov by Sentry. |
Santino-Trade
approved these changes
Jul 1, 2024
Santino-Trade
added a commit
that referenced
this pull request
Jul 1, 2024
* Upgrading postgres to 16 (#737) Co-authored-by: santinomolinaro <santino.molinaro@mail> * TSS-1612: Prepare s3 client for migration (#751) * tss-1612: S3 copilot switch * Copilto DB URL * format --------- Co-authored-by: abarolo <[email protected]> * TSS-1615: Pingdom healthcheck (#752) * tss-1612: S3 copilot switch * tss-1615: Pingdom API healthcheck * url update * format --------- Co-authored-by: abarolo <[email protected]> * chore: add .copilot directory with files required for image building * TSS-1416: Xray & ASIM logging (#755) * TSS-1416: Xray * ASIM logging * dbt-copilot-python dep * Switch logging based on platform * Handle all 3 loggers --------- Co-authored-by: abarolo <[email protected]> * chore: force pipeline build * chore: update packeto builder version * TSS-1615: celery config (#768) * tss-1615: celery config * format --------- Co-authored-by: abarolo <[email protected]> * TSS-1615: celery config (#768) * tss-1615: celery config * format --------- Co-authored-by: abarolo <[email protected]> * Add sample trace rate for APM * Revert IAM roles to access public buckets * remove unused import * Update S3 client for documents * Trigger deploy * Restore boto session config when on DBT Platform * Debug download url for av scan * Add more debug to see where this is failing * Trigger deploy * Remove debugging * chore: update poetry.lock and requirements files * tss-1802: check history exists in publish flow (#797) * check history exists in publish * log --------- Co-authored-by: abarolo <[email protected]> * update (#798) Co-authored-by: abarolo <[email protected]> * Increase gunicorn worker timeout (#799) Co-authored-by: abarolo <[email protected]> * Upgrade gevent (#800) Co-authored-by: abarolo <[email protected]> * Reduce worker connection count (#801) Co-authored-by: abarolo <[email protected]> * (TEST) revert Procfile + remove temp file creation for s3 upload * Use in memory data upload to s3 (#802) Co-authored-by: abarolo <[email protected]> * PAAS Migration branch cleanup (#803) * Logging tasks and local celery + flower (#789) * format --------- Co-authored-by: abarolo <[email protected]> * tss-1783: Add set_to_allowed_on to data workspace serializer (#790) * tss-1783: Add set_to_allowed_on to data workspace serializer --------- Co-authored-by: abarolo <[email protected]> * rc/maybe-maybe-not-2 (#792) * Bump tqdm from 4.66.2 to 4.66.3 Bumps [tqdm](https://github.com/tqdm/tqdm) from 4.66.2 to 4.66.3. - [Release notes](https://github.com/tqdm/tqdm/releases) - [Commits](tqdm/tqdm@v4.66.2...v4.66.3) --- updated-dependencies: - dependency-name: tqdm dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Regenerating requirements.txt file * Bump jinja2 from 3.1.3 to 3.1.4 (#788) * Bump jinja2 from 3.1.3 to 3.1.4 Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Regenerating requirements.txt file --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Bump werkzeug from 3.0.2 to 3.0.3 (#787) * Bump werkzeug from 3.0.2 to 3.0.3 Bumps [werkzeug](https://github.com/pallets/werkzeug) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/pallets/werkzeug/releases) - [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst) - [Commits](pallets/werkzeug@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: werkzeug dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Regenerating requirements.txt file --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * TSS-1791 Updating Readme (#791) * Updating README to include updates for mock SSO to the hosts file * Removing whitespace --------- Co-authored-by: Uka Osim <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Elizabeth Pedley <[email protected]> * feature/TSS-1790-move-notification-to-signals-to-celery-background-tasks (#794) * feat: moving email to celery task * feat: moving email to celery task * feat: moving email to celery task * lint fix * lint fix * feat: moving signal handlers to barrier tasks * removing non required imports * Extra logging for authorised requests (#793) * Formatting and test fixes * format * test * Fix last test * format --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: abarolo <[email protected]> Co-authored-by: Uka Osim <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Elizabeth Pedley <[email protected]> Co-authored-by: Feroze Rub <[email protected]> * Elastic APM is a boolean * Trigger deploy * Trigger deploy * trigger deploy * tss-1747: Add Publisher and Approver as TeamMembers to barrier flow (#811) * tss-1747: Add Publisher and Approver as TeamMembers to barrier flow * format --------- Co-authored-by: abarolo <[email protected]> * TSS/1522: adding market distorting practices tag (#812) * Formatting * Updating test to accomodate new tag * Updating for readability * Removing dynamic order so that it runs quicker and hardcoding * Improving readability * Fixing 'create() takes 1 positional argument but 2 were given' error * tss-1874: Re-instate is top 100 priority in barrier downloads (#817) * Release Candidate - Spring Break (#813) * Upgrading postgres to 16 (#737) Co-authored-by: santinomolinaro <santino.molinaro@mail> * TSS-1612: Prepare s3 client for migration (#751) * tss-1612: S3 copilot switch * Copilto DB URL * format --------- Co-authored-by: abarolo <[email protected]> * TSS-1615: Pingdom healthcheck (#752) * tss-1612: S3 copilot switch * tss-1615: Pingdom API healthcheck * url update * format --------- Co-authored-by: abarolo <[email protected]> * chore: add .copilot directory with files required for image building * TSS-1416: Xray & ASIM logging (#755) * TSS-1416: Xray * ASIM logging * dbt-copilot-python dep * Switch logging based on platform * Handle all 3 loggers --------- Co-authored-by: abarolo <[email protected]> * chore: force pipeline build * chore: update packeto builder version * TSS-1615: celery config (#768) * tss-1615: celery config * format --------- Co-authored-by: abarolo <[email protected]> * TSS-1615: celery config (#768) * tss-1615: celery config * format --------- Co-authored-by: abarolo <[email protected]> * Add sample trace rate for APM * Revert IAM roles to access public buckets * remove unused import * Update S3 client for documents * Trigger deploy * Restore boto session config when on DBT Platform * Debug download url for av scan * Add more debug to see where this is failing * Trigger deploy * Remove debugging * chore: update poetry.lock and requirements files * tss-1802: check history exists in publish flow (#797) * check history exists in publish * log --------- Co-authored-by: abarolo <[email protected]> * update (#798) Co-authored-by: abarolo <[email protected]> * Increase gunicorn worker timeout (#799) Co-authored-by: abarolo <[email protected]> * Upgrade gevent (#800) Co-authored-by: abarolo <[email protected]> * Reduce worker connection count (#801) Co-authored-by: abarolo <[email protected]> * (TEST) revert Procfile + remove temp file creation for s3 upload * Use in memory data upload to s3 (#802) Co-authored-by: abarolo <[email protected]> * PAAS Migration branch cleanup (#803) * Logging tasks and local celery + flower (#789) * format --------- Co-authored-by: abarolo <[email protected]> * tss-1783: Add set_to_allowed_on to data workspace serializer (#790) * tss-1783: Add set_to_allowed_on to data workspace serializer --------- Co-authored-by: abarolo <[email protected]> * rc/maybe-maybe-not-2 (#792) * Bump tqdm from 4.66.2 to 4.66.3 Bumps [tqdm](https://github.com/tqdm/tqdm) from 4.66.2 to 4.66.3. - [Release notes](https://github.com/tqdm/tqdm/releases) - [Commits](tqdm/tqdm@v4.66.2...v4.66.3) --- updated-dependencies: - dependency-name: tqdm dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Regenerating requirements.txt file * Bump jinja2 from 3.1.3 to 3.1.4 (#788) * Bump jinja2 from 3.1.3 to 3.1.4 Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Regenerating requirements.txt file --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Bump werkzeug from 3.0.2 to 3.0.3 (#787) * Bump werkzeug from 3.0.2 to 3.0.3 Bumps [werkzeug](https://github.com/pallets/werkzeug) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/pallets/werkzeug/releases) - [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst) - [Commits](pallets/werkzeug@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: werkzeug dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Regenerating requirements.txt file --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * TSS-1791 Updating Readme (#791) * Updating README to include updates for mock SSO to the hosts file * Removing whitespace --------- Co-authored-by: Uka Osim <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Elizabeth Pedley <[email protected]> * feature/TSS-1790-move-notification-to-signals-to-celery-background-tasks (#794) * feat: moving email to celery task * feat: moving email to celery task * feat: moving email to celery task * lint fix * lint fix * feat: moving signal handlers to barrier tasks * removing non required imports * Extra logging for authorised requests (#793) * Formatting and test fixes * format * test * Fix last test * format --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: abarolo <[email protected]> Co-authored-by: Uka Osim <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Elizabeth Pedley <[email protected]> Co-authored-by: Feroze Rub <[email protected]> * Elastic APM is a boolean * Trigger deploy * Trigger deploy * trigger deploy * tss-1747: Add Publisher and Approver as TeamMembers to barrier flow (#811) * tss-1747: Add Publisher and Approver as TeamMembers to barrier flow * format --------- Co-authored-by: abarolo <[email protected]> * TSS/1522: adding market distorting practices tag (#812) * Formatting * Updating test to accomodate new tag * Updating for readability * Removing dynamic order so that it runs quicker and hardcoding * Improving readability * Fixing 'create() takes 1 positional argument but 2 were given' error --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Santino Molinaro <[email protected]> Co-authored-by: santinomolinaro <santino.molinaro@mail> Co-authored-by: abarolo <[email protected]> Co-authored-by: abarolo <[email protected]> Co-authored-by: Gareth Pitt-Nash <[email protected]> Co-authored-by: Emile Swarts <[email protected]> Co-authored-by: Yusuf <[email protected]> Co-authored-by: Uka Osim <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Elizabeth Pedley <[email protected]> * tss-1874: Re-instate is top 100 priority in barrier downloads --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Feroze Rub <[email protected]> Co-authored-by: Santino Molinaro <[email protected]> Co-authored-by: santinomolinaro <santino.molinaro@mail> Co-authored-by: abarolo <[email protected]> Co-authored-by: Gareth Pitt-Nash <[email protected]> Co-authored-by: Emile Swarts <[email protected]> Co-authored-by: Yusuf <[email protected]> Co-authored-by: Uka Osim <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Elizabeth Pedley <[email protected]> * TSS/1904: Updating Dependabots (#814) * Release Candidate - Spring Break (#813) * Upgrading postgres to 16 (#737) Co-authored-by: santinomolinaro <santino.molinaro@mail> * TSS-1612: Prepare s3 client for migration (#751) * tss-1612: S3 copilot switch * Copilto DB URL * format --------- Co-authored-by: abarolo <[email protected]> * TSS-1615: Pingdom healthcheck (#752) * tss-1612: S3 copilot switch * tss-1615: Pingdom API healthcheck * url update * format --------- Co-authored-by: abarolo <[email protected]> * chore: add .copilot directory with files required for image building * TSS-1416: Xray & ASIM logging (#755) * TSS-1416: Xray * ASIM logging * dbt-copilot-python dep * Switch logging based on platform * Handle all 3 loggers --------- Co-authored-by: abarolo <[email protected]> * chore: force pipeline build * chore: update packeto builder version * TSS-1615: celery config (#768) * tss-1615: celery config * format --------- Co-authored-by: abarolo <[email protected]> * TSS-1615: celery config (#768) * tss-1615: celery config * format --------- Co-authored-by: abarolo <[email protected]> * Add sample trace rate for APM * Revert IAM roles to access public buckets * remove unused import * Update S3 client for documents * Trigger deploy * Restore boto session config when on DBT Platform * Debug download url for av scan * Add more debug to see where this is failing * Trigger deploy * Remove debugging * chore: update poetry.lock and requirements files * tss-1802: check history exists in publish flow (#797) * check history exists in publish * log --------- Co-authored-by: abarolo <[email protected]> * update (#798) Co-authored-by: abarolo <[email protected]> * Increase gunicorn worker timeout (#799) Co-authored-by: abarolo <[email protected]> * Upgrade gevent (#800) Co-authored-by: abarolo <[email protected]> * Reduce worker connection count (#801) Co-authored-by: abarolo <[email protected]> * (TEST) revert Procfile + remove temp file creation for s3 upload * Use in memory data upload to s3 (#802) Co-authored-by: abarolo <[email protected]> * PAAS Migration branch cleanup (#803) * Logging tasks and local celery + flower (#789) * format --------- Co-authored-by: abarolo <[email protected]> * tss-1783: Add set_to_allowed_on to data workspace serializer (#790) * tss-1783: Add set_to_allowed_on to data workspace serializer --------- Co-authored-by: abarolo <[email protected]> * rc/maybe-maybe-not-2 (#792) * Bump tqdm from 4.66.2 to 4.66.3 Bumps [tqdm](https://github.com/tqdm/tqdm) from 4.66.2 to 4.66.3. - [Release notes](https://github.com/tqdm/tqdm/releases) - [Commits](tqdm/tqdm@v4.66.2...v4.66.3) --- updated-dependencies: - dependency-name: tqdm dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Regenerating requirements.txt file * Bump jinja2 from 3.1.3 to 3.1.4 (#788) * Bump jinja2 from 3.1.3 to 3.1.4 Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Regenerating requirements.txt file --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Bump werkzeug from 3.0.2 to 3.0.3 (#787) * Bump werkzeug from 3.0.2 to 3.0.3 Bumps [werkzeug](https://github.com/pallets/werkzeug) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/pallets/werkzeug/releases) - [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst) - [Commits](pallets/werkzeug@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: werkzeug dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Regenerating requirements.txt file --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * TSS-1791 Updating Readme (#791) * Updating README to include updates for mock SSO to the hosts file * Removing whitespace --------- Co-authored-by: Uka Osim <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Elizabeth Pedley <[email protected]> * feature/TSS-1790-move-notification-to-signals-to-celery-background-tasks (#794) * feat: moving email to celery task * feat: moving email to celery task * feat: moving email to celery task * lint fix * lint fix * feat: moving signal handlers to barrier tasks * removing non required imports * Extra logging for authorised requests (#793) * Formatting and test fixes * format * test * Fix last test * format --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: abarolo <[email protected]> Co-authored-by: Uka Osim <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Elizabeth Pedley <[email protected]> Co-authored-by: Feroze Rub <[email protected]> * Elastic APM is a boolean * Trigger deploy * Trigger deploy * trigger deploy * tss-1747: Add Publisher and Approver as TeamMembers to barrier flow (#811) * tss-1747: Add Publisher and Approver as TeamMembers to barrier flow * format --------- Co-authored-by: abarolo <[email protected]> * TSS/1522: adding market distorting practices tag (#812) * Formatting * Updating test to accomodate new tag * Updating for readability * Removing dynamic order so that it runs quicker and hardcoding * Improving readability * Fixing 'create() takes 1 positional argument but 2 were given' error --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Santino Molinaro <[email protected]> Co-authored-by: santinomolinaro <santino.molinaro@mail> Co-authored-by: abarolo <[email protected]> Co-authored-by: abarolo <[email protected]> Co-authored-by: Gareth Pitt-Nash <[email protected]> Co-authored-by: Emile Swarts <[email protected]> Co-authored-by: Yusuf <[email protected]> Co-authored-by: Uka Osim <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Elizabeth Pedley <[email protected]> * Updating Dependabots --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Feroze Rub <[email protected]> Co-authored-by: Santino Molinaro <[email protected]> Co-authored-by: santinomolinaro <santino.molinaro@mail> Co-authored-by: abarolo <[email protected]> Co-authored-by: abarolo <[email protected]> Co-authored-by: Gareth Pitt-Nash <[email protected]> Co-authored-by: Emile Swarts <[email protected]> Co-authored-by: Yusuf <[email protected]> Co-authored-by: Uka Osim <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * tss-1850: Backfill barrier set_to_allowed_on (#815) * tss-1850: Backfill barrier set_to_allowed_on * Fix migration --------- Co-authored-by: abarolo <[email protected]> * Removing code no longer used after implementing MAU (#816) * Removing code no longer used after implementing MAU * Updating migration numbers * Update to migration for existing barriers * Migration fix --------- Co-authored-by: santinomolinaro <santino.molinaro@mail> Co-authored-by: Feroze Rub <[email protected]> * TSS-1865-dmas-filtering-issue (#823) * adding a filter for valuation assessment * added test case for valuation_assessment * fixing lint issues * TSS-1694-1695: Data workspace additions (#822) * valuation first added * TSS-1694 * format --------- Co-authored-by: abarolo <[email protected]> * TSS-1696: top priority summary date (#819) * tss-1696: Return most recent date that barrier was set as top priority to DW * Add top priority user to DW serializer --------- Co-authored-by: abarolo <[email protected]> Co-authored-by: root <root@localhost> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: santinomolinaro <santino.molinaro@mail> Co-authored-by: abarolo <[email protected]> Co-authored-by: abarolo <[email protected]> Co-authored-by: Gareth Pitt-Nash <[email protected]> Co-authored-by: Feroze Rub <[email protected]> Co-authored-by: Emile Swarts <[email protected]> Co-authored-by: Yusuf <[email protected]> Co-authored-by: Uka Osim <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Elizabeth Pedley <[email protected]> Co-authored-by: root <root@localhost>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.