Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #831

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Develop #831

merged 4 commits into from
Jul 3, 2024

Conversation

Santino-Trade
Copy link
Contributor

No description provided.

Santino-Trade and others added 3 commits July 3, 2024 14:56
* Delete automated financial assesments

Remove the run automated assessments functionality due the removal of comtrade datasets

Delete redundant tests

Fix assessment detal test

Fix tests

Remove last references to Comtrade

Remove the last references to comtrade in docker compose and tests.

update black version

Remove comments

Tidy up- remove commented code

* Tidy up

---------

Co-authored-by: Feroze Rub <[email protected]>
format

format

date_barrier_prioritised field

Rename top_priority_date > top_priority_requested_date

format

fix test

format

Co-authored-by: abarolo <[email protected]>
Co-authored-by: santinomolinaro <santino.molinaro@mail>
@Santino-Trade Santino-Trade requested a review from a team as a code owner July 3, 2024 15:24
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.04%. Comparing base (4687916) to head (e8d6527).

Files Patch % Lines
api/barriers/serializers/data_workspace.py 94.73% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
- Coverage   86.45%   86.04%   -0.41%     
==========================================
  Files         166      157       -9     
  Lines        8303     7961     -342     
==========================================
- Hits         7178     6850     -328     
+ Misses       1125     1111      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ferozerub ferozerub merged commit 74430fb into master Jul 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants