Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding free-text-search to related barriers #845

Conversation

Santino-Trade
Copy link
Contributor

@Santino-Trade Santino-Trade commented Jul 16, 2024

New endpoint:

/related-barriers?search_term=xxx

Allows textual search of barrier embeddings

@Santino-Trade Santino-Trade requested a review from a team as a code owner July 16, 2024 16:54
@abarolo abarolo deleted the branch TSS-1937-dmas-dashboard-build-parent-ticket July 30, 2024 08:45
@abarolo abarolo closed this Jul 30, 2024
@abarolo abarolo reopened this Aug 2, 2024
@abarolo abarolo force-pushed the develop branch 2 times, most recently from dedf76a to a8ddffa Compare August 7, 2024 07:57
@abarolo abarolo changed the base branch from develop to master August 7, 2024 07:58
@abarolo abarolo changed the base branch from master to develop August 7, 2024 07:58
@abarolo abarolo force-pushed the TSS-1963_Free-Text-Search-Related-Barriers branch from 546a34e to c090418 Compare August 7, 2024 08:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 66 lines in your changes missing coverage. Please review.

Project coverage is 85.40%. Comparing base (0d4427b) to head (8fe0065).

Files Patch % Lines
api/related_barriers/manager.py 14.89% 40 Missing ⚠️
api/related_barriers/views.py 18.51% 22 Missing ⚠️
api/related_barriers/serializers.py 73.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #845      +/-   ##
===========================================
- Coverage    86.09%   85.40%   -0.69%     
===========================================
  Files          158      158              
  Lines         7989     8060      +71     
===========================================
+ Hits          6878     6884       +6     
- Misses        1111     1176      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osimuka osimuka changed the base branch from develop to TSS-1937-dmas-dashboard-build-parent-ticket August 27, 2024 09:30
@osimuka osimuka merged commit e8b9f2a into TSS-1937-dmas-dashboard-build-parent-ticket Aug 27, 2024
0 of 3 checks passed
@osimuka osimuka deleted the TSS-1963_Free-Text-Search-Related-Barriers branch August 27, 2024 13:57
ferozerub added a commit that referenced this pull request Sep 16, 2024
* Adding free-text-search to related barriers (#845)

* Adding free-text-search to related barriers

* Rebase

* Update and working search endpoint

* format

* format

* Excluding archived barriers from inactive notification alerts (#858)

Co-authored-by: santinomolinaro <santino.molinaro@mail>

* Deleting cached barrier when creating and updating next steps items so they are reflected instantly on frontend (#861)

Co-authored-by: santinomolinaro <santino.molinaro@mail>

* TSS-1995: Move set_to_allowed_on into public barrier serializer (#862)

* tss-1995: set_to_allowed expected on public_barrier serializer

---------

Co-authored-by: abarolo <[email protected]>

* updates

* format

* format

* using the full text search on the search page

* lint fix

---------

Co-authored-by: santinomolinaro <santino.molinaro@mail>
Co-authored-by: abarolo <[email protected]>
Co-authored-by: abarolo <[email protected]>
Co-authored-by: Uka Osim <[email protected]>
Co-authored-by: Uka Osim <[email protected]>

* feat: lint fix

* raise search limit

* test fix

* TSS 1966 dashboard summary with filters (#885)

* hotfix: Reduce Dataworkspace pagination size (#877)

* hotfix: Reduce Dataworkspace pagination size

---------

Co-authored-by: abarolo <[email protected]>

* Basic summary info

Basic summary stats exposed with filter set implemented

* Fix filtering

* Remove comments

* Add financial year

---------

Co-authored-by: abarolo <[email protected]>
Co-authored-by: abarolo <[email protected]>

* Tss 1965 dashboard tasks merge branch (#888)

* Adding Dashboard Task list view to calculate outstanding tasks for display on new dashboard

* Unit tests and edge case fixes

* Limiting initial query to 1000 results, and order by last modified on date

---------

Co-authored-by: santinomolinaro <santino.molinaro@mail>

* Dashboard chart data (#898)

* Fix PB100 filter (#890)

---------

Co-authored-by: santinomolinaro <santino.molinaro@mail>
Co-authored-by: abarolo <[email protected]>
Co-authored-by: abarolo <[email protected]>
Co-authored-by: Uka Osim <[email protected]>
Co-authored-by: Uka Osim <[email protected]>
Co-authored-by: Feroze Rub <[email protected]>
abarolo added a commit that referenced this pull request Sep 17, 2024
* Dashboard Parent Ticket (#896)

* Adding free-text-search to related barriers (#845)

* Adding free-text-search to related barriers

* Rebase

* Update and working search endpoint

* Excluding archived barriers from inactive notification alerts (#858)

Co-authored-by: santinomolinaro <santino.molinaro@mail>

* Deleting cached barrier when creating and updating next steps items so they are reflected instantly on frontend (#861)

Co-authored-by: santinomolinaro <santino.molinaro@mail>

* TSS-1995: Move set_to_allowed_on into public barrier serializer (#862)

* tss-1995: set_to_allowed expected on public_barrier serializer

---------

Co-authored-by: abarolo <[email protected]>

* using the full text search on the search page

---------

Co-authored-by: santinomolinaro <santino.molinaro@mail>
Co-authored-by: abarolo <[email protected]>
Co-authored-by: abarolo <[email protected]>
Co-authored-by: Uka Osim <[email protected]>
Co-authored-by: Uka Osim <[email protected]>

* feat: lint fix

* raise search limit

* test fix

* TSS 1966 dashboard summary with filters (#885)

* hotfix: Reduce Dataworkspace pagination size (#877)

* hotfix: Reduce Dataworkspace pagination size

---------

Co-authored-by: abarolo <[email protected]>

* Basic summary info

Basic summary stats exposed with filter set implemented

* Fix filtering

* Remove comments

* Add financial year

---------

Co-authored-by: abarolo <[email protected]>
Co-authored-by: abarolo <[email protected]>

* Tss 1965 dashboard tasks merge branch (#888)

* Adding Dashboard Task list view to calculate outstanding tasks for display on new dashboard

* Unit tests and edge case fixes

* Limiting initial query to 1000 results, and order by last modified on date

---------

Co-authored-by: santinomolinaro <santino.molinaro@mail>

* Dashboard chart data (#898)

* Fix PB100 filter (#890)

---------

Co-authored-by: santinomolinaro <santino.molinaro@mail>
Co-authored-by: abarolo <[email protected]>
Co-authored-by: abarolo <[email protected]>
Co-authored-by: Uka Osim <[email protected]>
Co-authored-by: Uka Osim <[email protected]>
Co-authored-by: Feroze Rub <[email protected]>

* Delete barrier detail cache (#899)

Co-authored-by: abarolo <[email protected]>

* Remove test command (#901)

Co-authored-by: abarolo <[email protected]>

---------

Co-authored-by: Santino Molinaro <[email protected]>
Co-authored-by: santinomolinaro <santino.molinaro@mail>
Co-authored-by: abarolo <[email protected]>
Co-authored-by: Uka Osim <[email protected]>
Co-authored-by: Uka Osim <[email protected]>
Co-authored-by: Feroze Rub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants