Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DBTP-1373 - Handle SchemaErrors from platform config validation gracefully #584

Merged
merged 74 commits into from
Sep 30, 2024

Conversation

ksugden
Copy link
Contributor

@ksugden ksugden commented Sep 26, 2024

Addresses DBTP-1373

When a config validation failed during platform-helper commands, an exception was thrown, resulting in a large traceback and an obscured reason for the schema validation error.

This PR catches the schema validation error and exits platform-helper gracefully, outputting only the schema validation error message.

The tests are updated for the expected SystemExit exception.


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • If the work includes user interface changes, before and after screenshots included in description
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

ksugden and others added 30 commits September 19, 2024 14:26
@ksugden ksugden changed the base branch from main to DBTP-1375-fix-platform-helper-validation-output September 26, 2024 11:08
@ksugden ksugden changed the title fix: handle requests exceptions gracefully fix: DBTP-1373 - Handle SchemaErrors from platform config validation gracefully Sep 26, 2024
@ksugden ksugden marked this pull request as ready for review September 27, 2024 08:49
Base automatically changed from DBTP-1375-fix-platform-helper-validation-output to main September 27, 2024 10:46
@ksugden ksugden merged commit 8324049 into main Sep 30, 2024
6 checks passed
@ksugden ksugden deleted the DBTP-1373-handle-platform-helper-exceptions-gracefully branch September 30, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants