-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DBTP-1373 - Handle SchemaErrors from platform config validation gracefully #584
Merged
ksugden
merged 74 commits into
main
from
DBTP-1373-handle-platform-helper-exceptions-gracefully
Sep 30, 2024
Merged
fix: DBTP-1373 - Handle SchemaErrors from platform config validation gracefully #584
ksugden
merged 74 commits into
main
from
DBTP-1373-handle-platform-helper-exceptions-gracefully
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_versions function
…s evaluated at import
ksugden
changed the base branch from
main
to
DBTP-1375-fix-platform-helper-validation-output
September 26, 2024 11:08
ksugden
changed the title
fix: handle requests exceptions gracefully
fix: DBTP-1373 - Handle SchemaErrors from platform config validation gracefully
Sep 26, 2024
…BTP-1373-handle-platform-helper-exceptions-gracefully
gabelton
approved these changes
Sep 27, 2024
Base automatically changed from
DBTP-1375-fix-platform-helper-validation-output
to
main
September 27, 2024 10:46
ksugden
deleted the
DBTP-1373-handle-platform-helper-exceptions-gracefully
branch
September 30, 2024 08:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DBTP-1373
When a config validation failed during
platform-helper
commands, an exception was thrown, resulting in a large traceback and an obscured reason for the schema validation error.This PR catches the schema validation error and exits platform-helper gracefully, outputting only the schema validation error message.
The tests are updated for the expected SystemExit exception.
Checklist:
Title:
Description:
Tasks: