TP-1023-Synthetic-records-may-not-obey-record-subrecord-order #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuaxo
changed the title
stuaxo
force-pushed
the
TP-1023-Synthetic-records-may-not-obey-record-subrecord-order
branch
2 times, most recently
from
ccc1fc2
to
27ce070
Compare
stuaxo
changed the base branch from
TP-841-ensure-transaction-ids-are-contiguous-on-publishing
to
master
…ed_model fields, this highlights issues where synthetic fields (such as descriptions) attached to tracked_models can break record, subrecord ordering when placed in transactions together.
stuaxo
force-pushed
the
TP-1023-Synthetic-records-may-not-obey-record-subrecord-order
branch
from
27ce070
to
d92fdb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synthetic records, such as descriptions have their own record, and subrecord numbers, currently
they are output along side their respective tracked models.
When outputting more than one tracked model that is associated with a synthetic record record, subrecord ordering is broken, our tests didn't catch this before.
This draft PR add enables tests of factories that demonstrate the issue (and thus fail).