Addition of variable JPEG2000 compression for different sizes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
High JPEG2000 compression levels result in excellent results at large image dimensions, but can cause very visible artefacting for smaller icon dimensions. This commit applies the specified compression level for the large image sizes, applies less compression for 512*512 and 256*256 sizes, and disables compression for smaller sizes; this allows JPEG2000 compression to be increased overall for much smaller file sizes with no visible loss in quality, producing excellent output at compression levels of 0.2-05 for most icons. Also outputs the compression level being used for each size in the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make specified JPEG2000 compression apply variably across different icon sizes. Results in much smaller overall size with no visible loss of quality by allowing higher JPEG2000 compression level to be specified.
From the main commit note:
High JPEG2000 compression levels result in excellent results at large image dimensions, but can cause very visible artefacting for smaller icon dimensions. This commit applies the specified compression level for the large image sizes, applies less compression for 512_512 and 256_256 sizes, and disables compression for smaller sizes; this allows JPEG2000 compression to be increased overall for much smaller file sizes with no visible loss in quality, producing excellent output at compression levels of 0.2-05 for most icons.
Also outputs the compression level being used for each size in the output