Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation #58

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Segmentation #58

wants to merge 32 commits into from

Conversation

john-rocky
Copy link
Contributor

@john-rocky john-rocky commented Aug 18, 2024

This branch adds segmentation functionality to the app.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Added instance segmentation support and UI enhancements to YOLO iOS app.

πŸ“Š Key Changes

  • Integrated YOLOv8 instance segmentation models alongside existing detection models.
  • Updated UI with a new segment control to toggle between detection and segmentation tasks.
  • Added Colors.swift and PostProcessSegment.swift for enhanced visual display.
  • Modified storyboard for improved layout and new segment control.
  • Refined export script in README for model conversion and placement.

🎯 Purpose & Impact

  • Enhanced Functionality: Users can now choose between object detection and segmentation for more detailed image analysis. πŸ–ΌοΈ
  • Improved UX: A revamped interface allows switching tasks easily, providing a more user-friendly experience. πŸ–₯️
  • Visual Improvements: Added color palette for segment masks, enhancing visual output. 🌈

@UltralyticsAssistant UltralyticsAssistant added APP enhancement New feature or request labels Aug 18, 2024
@john-rocky john-rocky mentioned this pull request Aug 18, 2024
@ambitious-octopus ambitious-octopus changed the title Seg Segmentation Aug 18, 2024
Copy link
Member

@ambitious-octopus ambitious-octopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@john-rocky Can you update the README.md and specify that segmentation models should also be exported?

YOLO/ViewController.swift Show resolved Hide resolved
@john-rocky
Copy link
Contributor Author

john-rocky commented Aug 18, 2024

@ambitious-octopus
I also added conversion of the seg model to the export script in README.md.
However, for the option to download the model from GitHub Release Assets, we will need to add the seg model to your GitHub Release Assets.

YOLO.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
YOLO.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
YOLO/Models/README.md Outdated Show resolved Hide resolved
Copy link
Member

@ambitious-octopus ambitious-octopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's better, @john-rocky did you test this PR independently?

YOLO.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
YOLO.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
YOLO.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
YOLO.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
YOLO.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
YOLO/Utilities/PostProcessSegment.swift Show resolved Hide resolved
Copy link
Member

@ambitious-octopus ambitious-octopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @john-rocky Is this ready?

@john-rocky
Copy link
Contributor Author

@ambitious-octopus Yes, now this branch works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TODO High priority items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants