Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report errors during Telamon-gen parsing #5

Open
1 of 10 tasks
ulysseB opened this issue Mar 29, 2018 · 1 comment
Open
1 of 10 tasks

Report errors during Telamon-gen parsing #5

ulysseB opened this issue Mar 29, 2018 · 1 comment
Assignees
Labels
A-telamon-gen enhancement New feature or request

Comments

@ulysseB
Copy link
Owner

ulysseB commented Mar 29, 2018

Currently, Telamon-gen generates a backtrace when it encounters a user error. This makes it hard to use. It should report errors with line and column numbers instead.

Remaining actions:

  • Separate declaration and definition
  • Sets type checking and declaration
  • Generic choices type checking
  • Enum type checking and declaration
  • Integer type checking and declaration
  • NumericSet type checking and declaration
  • Counter type checking and declaration
  • Constraint type checking and declaration
  • Trigger type checking and declaration
  • Quotient sets type checking and delclaration
@ulysseB ulysseB added enhancement New feature or request A-telamon-gen labels Mar 29, 2018
ulysseB pushed a commit that referenced this issue May 23, 2018
* Lexer captures InvalidToken and parser returns it as a 
* Positions can now be implemented by @l and @r tokens at Lalrpop #5 .
* The F/lex FFI part of lexer is now more documented.
* The token position is now checked and implemented from the Lexer grammar.
@ulysseB
Copy link
Owner Author

ulysseB commented Jun 15, 2018

Here are my comments on the current error checking:

  • many function could be factorized between IntegerDef, EnumDef and CounterDef. All three statements define a new choice so it makes sense. Moreover, the names of IntegerDef must not collide with the names of EnumDef and CounterDef.
  • Choice parameters should only be checked once sets are defined. Indeed the set may be defined after the enum in the input file.
  • the name parametric is used where it should be parameter
  • Some structures could be made private
  • Add doc comments to structures and enum variants

@ulysseB ulysseB assigned ulysseB and adjivas and unassigned ulysseB Jul 14, 2018
This was referenced Jul 25, 2018
bors bot added a commit that referenced this issue Jul 26, 2018
87: Spanned name for Var Definition r=adjivas a=adjivas

Short PR to prepare EnumDef check cases of issue #5 .

Co-authored-by: adjivas <[email protected]>
bors bot added a commit that referenced this issue Aug 2, 2018
89: Enumeration check r=adjivas a=adjivas

Check case for #5 .

* [x] undefined_field_antisymmetric: A antisymmetric should refers a defined fields from same enum.

Co-authored-by: adjivas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-telamon-gen enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants