Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanned name for Var Definition #87

Merged
merged 5 commits into from
Jul 26, 2018
Merged

Spanned name for Var Definition #87

merged 5 commits into from
Jul 26, 2018

Conversation

adjivas
Copy link
Contributor

@adjivas adjivas commented Jul 25, 2018

Short PR to prepare EnumDef check cases of issue #5 .

Copy link
Owner

@ulysseB ulysseB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the constraint file removed ?

let vars = untyped_vars.into_iter().map(|def| {
(def.name.clone(), var_map.decl_argument(&self.ir_desc, def))
let vars = untyped_vars.iter().map(|def| {
(def.name.clone(), var_map.decl_argument(&self.ir_desc, def.clone()))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to add a copy ?

Copy link
Contributor Author

@adjivas adjivas Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a regression, I will have to restore it.

@adjivas
Copy link
Contributor Author

adjivas commented Jul 26, 2018

constrain.rs and constraint.rs was same, that was a error of copy, that why I have removed this doublon.

@adjivas
Copy link
Contributor Author

adjivas commented Jul 26, 2018

bors r+

bors bot added a commit that referenced this pull request Jul 26, 2018
87: Spanned name for Var Definition r=adjivas a=adjivas

Short PR to prepare EnumDef check cases of issue #5 .

Co-authored-by: adjivas <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 26, 2018

Build succeeded

@bors bors bot merged commit 3be819c into ulysseB:master Jul 26, 2018
@adjivas adjivas deleted the spanned branch August 24, 2018 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants