-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanned name for Var Definition #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the constraint file removed ?
telamon-gen/src/ast/context.rs
Outdated
let vars = untyped_vars.into_iter().map(|def| { | ||
(def.name.clone(), var_map.decl_argument(&self.ir_desc, def)) | ||
let vars = untyped_vars.iter().map(|def| { | ||
(def.name.clone(), var_map.decl_argument(&self.ir_desc, def.clone())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to add a copy ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a regression, I will have to restore it.
constrain.rs and constraint.rs was same, that was a error of copy, that why I have removed this doublon. |
bors r+ |
87: Spanned name for Var Definition r=adjivas a=adjivas Short PR to prepare EnumDef check cases of issue #5 . Co-authored-by: adjivas <[email protected]>
Build succeeded |
Short PR to prepare EnumDef check cases of issue #5 .