Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve i18n #2924

Open
wants to merge 56 commits into
base: dev
Choose a base branch
from
Open

Improve i18n #2924

wants to merge 56 commits into from

Conversation

quiple
Copy link
Contributor

@quiple quiple commented Aug 28, 2024 •
edited
Loading

  • Uses react-intl for datetime format.
    • Replaces formatDate() with react-intl.
  • Replaces useCountryNames() with react-intl.
  • Replaces useLanguageNames() with react-intl.
  • Uses react-intl for number format.
    • Replaces formatLongNumber() with react-intl.
  • Localizes formatShortTime().

@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024

@quiple is attempting to deploy a commit to the umami-software Team on Vercel.

A member of the Team first needs to authorize it.

@quiple quiple marked this pull request as ready for review August 28, 2024 08:14
@quiple quiple marked this pull request as draft August 28, 2024 08:15
mikecao
mikecao approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@mikecao mikecao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🪂

@vercel Vercel
Copy link

vercel bot commented Aug 30, 2024

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@quiple quiple marked this pull request as ready for review August 30, 2024 13:40
DontAskForAnything
DontAskForAnything approved these changes Aug 30, 2024
View reviewed changes
Copy link

@DontAskForAnything DontAskForAnything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good improvement! 😄

@mikecao mikecao changed the base branch from master to dev October 25, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DontAskForAnything DontAskForAnything DontAskForAnything approved these changes

@mikecao mikecao mikecao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quiple @mikecao @DontAskForAnything